MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-1303

Wrong documentation for ExtensionsFilter init-param

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.1.7-SNAPSHOT
    • Fix Version/s: 1.1.7
    • Component/s: ExtensionsFilter
    • Labels:
      None

      Description

      On
      http://myfaces.apache.org/tomahawk/extensionsFilter.html
      there's an init-param named "maxFileSize", however, the code uses "uploadMaxFileSize".
      Also, documentation of the "uploadThresholdSize" init-param is missing.
      Please update the documentation.

        Activity

        Gertjan van Oosten created issue -
        Gertjan van Oosten made changes -
        Field Original Value New Value
        Component/s File Upload [ 12310747 ]
        Component/s ExtensionsFilter [ 12310927 ]
        Summary Wrong documentation for FileUpload init-param Wrong documentation for ExtensionsFilter init-param
        Hide
        Simon Kitching added a comment -

        Yep, thanks for pointing that out. I'll fix that soon..

        Show
        Simon Kitching added a comment - Yep, thanks for pointing that out. I'll fix that soon..
        Hide
        Simon Kitching added a comment -

        Ok, documentation has been updated and tomahawk site republished.
        See:

        • change to "Extensions Filter" page
        • change to t:inputFileUpload tagdoc
        • change to ExtensionFilter class javadoc

        Please check and then close as "resolved".

        Thanks for pointing the issue out.

        Show
        Simon Kitching added a comment - Ok, documentation has been updated and tomahawk site republished. See: change to "Extensions Filter" page change to t:inputFileUpload tagdoc change to ExtensionFilter class javadoc Please check and then close as "resolved". Thanks for pointing the issue out.
        Hide
        Gertjan van Oosten added a comment -

        Looks fine to me now. Thanks!

        Show
        Gertjan van Oosten added a comment - Looks fine to me now. Thanks!
        Gertjan van Oosten made changes -
        Fix Version/s 1.1.7-SNAPSHOT [ 12312361 ]
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Leonardo Uribe made changes -
        Fix Version/s 1.1.7-SNAPSHOT [ 12312361 ]
        Fix Version/s 1.1.7 [ 12313398 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Gertjan van Oosten
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development