MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-1082

t:messages does not put the class (error, info, fatal) to the li item when layout is "list"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.5, 1.1.6, 1.1.7-SNAPSHOT
    • Fix Version/s: 1.1.9
    • Component/s: Message(s)
    • Labels:
      None
    • Environment:
      myfaces 1.1.6-SNAPSHOT tomahawk 1.1.7-SNAPSHOT

      Description

      This could easily be error on the myfaces core but since I'm here and since it is also produced with t:messages I report it here. When using the default layout (list) the class of the t:messages is passed into a span inside the li items. This is making the differentiation of errors quite more difficult. To my understanding the RI puts those classes in the li.

        Issue Links

          Activity

          nikolaos georgosoulos created issue -
          nikolaos georgosoulos made changes -
          Field Original Value New Value
          Component/s Message(s) [ 12310941 ]
          Hide
          Leonardo Uribe added a comment -

          Right now this behavior is the default for myfaces core (because this is done on shared).

          For be more specific:

          MYFACES

          <ul>
          <li><span class="errorClass">message</span></li>
          </ul>

          RI

          <ul>
          <li class="errorClass">message</li>
          </ul>

          The same applies with layout="table"

          If something changes for t:messages, h:messages changes too.

          But reading the documentation of h:message and h:messages, it seems that there is no reference about how this should be done.

          If a change is done here to do this as RI does, the actual applications using myfaces changes too (css style fixes could be needed). But it seems that the right way to do this is something like this:

          <ul>
          <li class="errorClass"><span>message</span></li>
          </ul>

          But I'm not sure about do this. Suggestions?

          Show
          Leonardo Uribe added a comment - Right now this behavior is the default for myfaces core (because this is done on shared). For be more specific: MYFACES <ul> <li><span class="errorClass">message</span></li> </ul> RI <ul> <li class="errorClass">message</li> </ul> The same applies with layout="table" If something changes for t:messages, h:messages changes too. But reading the documentation of h:message and h:messages, it seems that there is no reference about how this should be done. If a change is done here to do this as RI does, the actual applications using myfaces changes too (css style fixes could be needed). But it seems that the right way to do this is something like this: <ul> <li class="errorClass"><span>message</span></li> </ul> But I'm not sure about do this. Suggestions?
          Leonardo Uribe made changes -
          Link This issue incorporates MYFACES-2139 [ MYFACES-2139 ]
          Hide
          Leonardo Uribe added a comment -

          Fixed on both branches on myfaces core and tomahawk (related issue MYFACES-2139)

          Show
          Leonardo Uribe added a comment - Fixed on both branches on myfaces core and tomahawk (related issue MYFACES-2139 )
          Leonardo Uribe made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Leonardo Uribe [ lu4242 ]
          Fix Version/s 1.1.9-SNAPSHOT [ 12313508 ]
          Resolution Fixed [ 1 ]
          Leonardo Uribe made changes -
          Fix Version/s 1.1.9 [ 12314035 ]
          Fix Version/s 1.1.9-SNAPSHOT [ 12313508 ]
          Leonardo Uribe made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Leonardo Uribe made changes -
          Link This issue is related to TOMAHAWK-1476 [ TOMAHAWK-1476 ]

            People

            • Assignee:
              Leonardo Uribe
              Reporter:
              nikolaos georgosoulos
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development