Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-995

Add Authenticator.newSaslNegotiator(InetAddress)

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: 3.1.0-incubating
    • Fix Version/s: 3.1.1-incubating
    • Component/s: server
    • Labels:
      None

      Description

      Add a new method to the Authenticator interface that will replace the current:

      public SaslNegotiator newSaslNegotiator();
      

      the preferred new method would be:

      public default SaslNegotiator newSaslNegotiator(final InetAddress remoteAddress)
      

      This will include deprecation of the old method - this is not a breaking change.

      .

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-tinkerpop/pull/162

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/162
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/162#issuecomment-162617213

        VOTE +1.

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/162#issuecomment-162617213 VOTE +1.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on a diff in the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/162#discussion_r46630315

        — Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/AllowAllAuthenticator.java —
        @@ -41,7 +42,16 @@ public AuthenticatedUser authenticate(final Map<String, String> credentials) thr
        return AuthenticatedUser.ANONYMOUS_USER;
        }

        + /**
        + * @deprecated As of release 3.1.1-incubating, replaced by

        {@link #newSaslNegotiator(InetAddress)}

        .
        + * @see <a href="https://issues.apache.org/jira/browse/TINKERPOP3-995">TINKERPOP3-995</a>
        — End diff –

        i'm not sure that we need to worry about the redirect dropping - i guess we could discuss a mass find/replace of that stuff. i was going to leave the old stuff as-is in my thinking this morning, but maybe we shouldn't. probably something to discuss on the list.

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/162#discussion_r46630315 — Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/AllowAllAuthenticator.java — @@ -41,7 +42,16 @@ public AuthenticatedUser authenticate(final Map<String, String> credentials) thr return AuthenticatedUser.ANONYMOUS_USER; } + /** + * @deprecated As of release 3.1.1-incubating, replaced by {@link #newSaslNegotiator(InetAddress)} . + * @see <a href="https://issues.apache.org/jira/browse/TINKERPOP3-995"> TINKERPOP3-995 </a> — End diff – i'm not sure that we need to worry about the redirect dropping - i guess we could discuss a mass find/replace of that stuff. i was going to leave the old stuff as-is in my thinking this morning, but maybe we shouldn't. probably something to discuss on the list.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user twilmes commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/162#issuecomment-161822807

        All the tests passed for me and the doc updates & code look good.

        VOTE +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user twilmes commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/162#issuecomment-161822807 All the tests passed for me and the doc updates & code look good. VOTE +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user twilmes commented on a diff in the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/162#discussion_r46629020

        — Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/AllowAllAuthenticator.java —
        @@ -41,7 +42,16 @@ public AuthenticatedUser authenticate(final Map<String, String> credentials) thr
        return AuthenticatedUser.ANONYMOUS_USER;
        }

        + /**
        + * @deprecated As of release 3.1.1-incubating, replaced by

        {@link #newSaslNegotiator(InetAddress)}

        .
        + * @see <a href="https://issues.apache.org/jira/browse/TINKERPOP3-995">TINKERPOP3-995</a>
        — End diff –

        This is about as tiny as it comes, but could the '3' be dropped to be consistent with the latest name update? Can't remember if they were ever going to drop the redirect. I'm sure there are others in the code so maybe instead, at some point a mass update could be made if we wanted.

        Show
        githubbot ASF GitHub Bot added a comment - Github user twilmes commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/162#discussion_r46629020 — Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/AllowAllAuthenticator.java — @@ -41,7 +42,16 @@ public AuthenticatedUser authenticate(final Map<String, String> credentials) thr return AuthenticatedUser.ANONYMOUS_USER; } + /** + * @deprecated As of release 3.1.1-incubating, replaced by {@link #newSaslNegotiator(InetAddress)} . + * @see <a href="https://issues.apache.org/jira/browse/TINKERPOP3-995"> TINKERPOP3-995 </a> — End diff – This is about as tiny as it comes, but could the '3' be dropped to be consistent with the latest name update? Can't remember if they were ever going to drop the redirect. I'm sure there are others in the code so maybe instead, at some point a mass update could be made if we wanted.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user spmallette opened a pull request:

        https://github.com/apache/incubator-tinkerpop/pull/162

        TINKERPOP3-995 Add Authenticator.newSaslNegotiator(InetAddress)

        https://issues.apache.org/jira/browse/TINKERPOP3-995

        This change is non-breaking despite the deprecation. Reviewers should focus on validating that there are no regressions:

        ```text
        mvn clean install
        mvn verify -DskipIntegrationTests=false -pl gremlin-server
        ```

        VOTE: +1

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-995

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-tinkerpop/pull/162.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #162


        commit 88b85c864ba82d0935a9834015e13358aaca46ec
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-11-26T12:41:19Z

        Deprecated Authenticator.newSaslNegotiator() and added new method to replace.

        commit aec1bfff9ead41a5c7ebad542b872bfb00adb43d
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-01T11:09:38Z

        Update upgrade docs on Authenticator changes.

        commit 6f8c580184dd3e02b94bed4764d3948ff785a249
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-01T12:07:33Z

        Updated changelog.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/162 TINKERPOP3-995 Add Authenticator.newSaslNegotiator(InetAddress) https://issues.apache.org/jira/browse/TINKERPOP3-995 This change is non-breaking despite the deprecation. Reviewers should focus on validating that there are no regressions: ```text mvn clean install mvn verify -DskipIntegrationTests=false -pl gremlin-server ``` VOTE: +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-995 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #162 commit 88b85c864ba82d0935a9834015e13358aaca46ec Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-11-26T12:41:19Z Deprecated Authenticator.newSaslNegotiator() and added new method to replace. commit aec1bfff9ead41a5c7ebad542b872bfb00adb43d Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-01T11:09:38Z Update upgrade docs on Authenticator changes. commit 6f8c580184dd3e02b94bed4764d3948ff785a249 Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-01T12:07:33Z Updated changelog.

          People

          • Assignee:
            spmallette stephen mallette
            Reporter:
            spmallette stephen mallette
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development