Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-913

Rename Gremlin Server arguments rebinding to alias

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: 3.0.2-incubating
    • Fix Version/s: 3.1.0-incubating
    • Component/s: driver, server
    • Labels:
      None

      Description

      The term "rebinding" is confusing whereas the word "alias" is a known word that users will get more readily. This work can be done through deprecation.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user spmallette opened a pull request:

        https://github.com/apache/incubator-tinkerpop/pull/135

        TINKERPOP3-913 Deprecate rebindings in favor of aliases

        https://issues.apache.org/jira/browse/TINKERPOP3-913

        to fully test this you have to:

        ```text
        mvn clean install
        cd gremlin-server
        mvn verify -DskipIntegrationTests=false
        ```

        VOTE: +1

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-913

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-tinkerpop/pull/135.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #135


        commit 180a6cb22c851273c688ff2d39f1d76ba877c987
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-11-04T17:42:09Z

        TINKERPOP3-913 Deprecated rebindings argument in favor of aliases.

        Should not be a breaking change as everything was done through deprecation.

        commit bdf0553420ef830f72e43b42b9c471e62a92dcf1
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-11-04T17:42:09Z

        TINKERPOP3-913 Deprecated rebindings argument in favor of aliases.

        Should not be a breaking change as everything was done through deprecation.

        commit 986bc7017bb12a7f609afece4f36f10881f10fd3
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-11-04T18:12:43Z

        Merge branch 'TINKERPOP3-913' of https://git-wip-us.apache.org/repos/asf/incubator-tinkerpop into TINKERPOP3-913


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/135 TINKERPOP3-913 Deprecate rebindings in favor of aliases https://issues.apache.org/jira/browse/TINKERPOP3-913 to fully test this you have to: ```text mvn clean install cd gremlin-server mvn verify -DskipIntegrationTests=false ``` VOTE: +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-913 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #135 commit 180a6cb22c851273c688ff2d39f1d76ba877c987 Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-11-04T17:42:09Z TINKERPOP3-913 Deprecated rebindings argument in favor of aliases. Should not be a breaking change as everything was done through deprecation. commit bdf0553420ef830f72e43b42b9c471e62a92dcf1 Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-11-04T17:42:09Z TINKERPOP3-913 Deprecated rebindings argument in favor of aliases. Should not be a breaking change as everything was done through deprecation. commit 986bc7017bb12a7f609afece4f36f10881f10fd3 Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-11-04T18:12:43Z Merge branch ' TINKERPOP3-913 ' of https://git-wip-us.apache.org/repos/asf/incubator-tinkerpop into TINKERPOP3-913
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user pluradj commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/135#issuecomment-153961084

        Ran the full test steps listed above, inspected the code, looks good to me.

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user pluradj commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/135#issuecomment-153961084 Ran the full test steps listed above, inspected the code, looks good to me. VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user PommeVerte commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/135#issuecomment-154050355

        The code looks good and all the tests pass.

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user PommeVerte commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/135#issuecomment-154050355 The code looks good and all the tests pass. VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/135#issuecomment-154051960

        RESULT: +1 (3 binding)

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/135#issuecomment-154051960 RESULT: +1 (3 binding)
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-tinkerpop/pull/135

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/135

          People

          • Assignee:
            spmallette stephen mallette
            Reporter:
            spmallette stephen mallette
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development