Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2821

Examine use of Tokens.ARGS_HOST as part of a RequestMessage

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.5.4
    • None
    • driver
    • None

    Description

      Tokens.ARGS_HOST seems to be used in different ways depending on whether it's being used in a RequestMessage where it expects a Host object (which is a bit odd - don't remember what the idea was there exactly) and in a ResponseMessage where it is assigned the channel.remoteAddress as a string in status metadata. I think the original idea was to allow the driver to have more control in a session where you could randomly pick any host, use the response to then reroute future requests to the same one based on the response metadata, but we never built the driver to really work that way. I'm not sure if i remember any of that properly though....maybe it was for something else? In any event, the currently functionality in Client.chooseConnection() that deals with the RequestMessage side likely isn't in use nor does it seem to be implemented how we would want it if it was to actually work. Seems worth examining more closely and likely just factoring that behavior out.

      Attachments

        Activity

          People

            Unassigned Unassigned
            spmallette Stephen Mallette
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: