[TINKERPOP-2589] XML External Entity (XXE) vulnerability

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.11
• Fix Version/s: 3.6.0, 3.4.13, 3.5.2
• Component/s: structure
• Assignee: Stephen Mallette
• Reporter: Saikiran Boga
• Created: 19/Jul/21 21:37
• Updated: 17/Aug/21 18:25
• Resolved: 27/Jul/21 11:30

Description

Found this from a security vulnerability scan. The following usage in gremlin-core package allows reading XML input stream and could potentially lead to XXE attack.

In general, when XML input containing a reference to an external entity is processed by a weakly configured XML parser, it can lead to an XML external entity (XXE) attack.

https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLReader.java#L396

More details on the vulnerability: https://owasp.org/www-community/vulnerabilities/XML_External_Entity_(XXE)_Processing

How to Fix: https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html#xmlinputfactory-a-stax-parser

 

Setting these properties on the XML factory should fix this:

inputFactory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, false);
inputFactory.setProperty(XMLInputFactory.SUPPORT_DTD, false);

Issue Links

• is duplicated by: TINKERPOP-2602 XML External Entity (XXE) vulnerability