Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2501

Websocket Connection handleError in javascript gremlin driver emits 'log' event instead of 'error'

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Not A Problem
    • None
    • None
    • javascript
    • None

    Description

      Description

      Javascript gremlin module has one weird logging behavior during client connection setup.

      The webSocket error event emits a handleError function https://github.com/apache/tinkerpop/blob/64ec9fbc9e6d368f1a251b25cf7b120ace09298c/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js#L155

      and this function emits the error message under log event i.e https://github.com/apache/tinkerpop/blob/64ec9fbc9e6d368f1a251b25cf7b120ace09298c/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js#L235.

      It looks like this was broken recently by https://github.com/apache/tinkerpop/commit/ab43b03514cf82fa004653c3a0d082e8a744107d this commit.

      I believe this should ideally be thrown under error event. Right now we have to listen to these connection errors under log event.

      I'll be happy to raise a pr for this once the bug gets approved by the core team.

       

      Attachments

        Activity

          People

            Unassigned Unassigned
            Pacifier Aditya Srivastava
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: