[TINKERPOP-2496] GremlinDslProcessor fails when SocialTraversalSourceDsl overrides close

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.9
• Fix Version/s: 3.5.0, 3.4.10
• Component/s: process
• Assignee: Stephen Mallette
• Reporter: Faron Dutton
• Created: 21/Dec/20 21:05
• Updated: 22/Dec/20 13:01
• Resolved: 22/Dec/20 13:01

Description

It appears that GremlinDslProcessor assumes all declared methods return some value. This causes it to fail if the traversal source DSL overrides the close method.

When compiling with Java 14, one receives the following error:

[ERROR] class com.sun.tools.javac.code.Type$JCVoidType cannot be cast to class javax.lang.model.type.DeclaredType (com.sun.tools.javac.code.Type$JCVoidType is in module jdk.compiler of loader 'app'; javax.lang.model.type.DeclaredType is in module java.compiler of loader 'platform')

Example Code

public class MyTraversalSourceDsl extends GraphTraversalSource {

    private static final Logger logger = LoggerFactory.getLogger(MyTraversalSourceDsl.class);

    public MyTraversalSourceDsl(final Graph graph, final TraversalStrategies traversalStrategies) {
        super(graph, traversalStrategies);
    }

    public MyTraversalSourceDsl(final Graph graph) {
        super(graph);
    }

    public MyTraversalSourceDsl(final RemoteConnection connection) {
        super(connection);
    }

    @Override
    public void close() {
        try {
            super.close();
        } catch (Exception e) {
            logger.error("Unable to close connection: {}", e.getMessage());
        }
    }

}