Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2483

Make WebSocketChannelizer non-final in Java driver

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Not A Problem
    • 3.4.8
    • None
    • driver
    • None

    Description

      With final keyword right now, it is not possible to extend WebSocketChannelizer. This is an obstruction for providers who want to add custom auth logic to the handlers. e.g. Amazon Neptune uses a fork of the Channelizer to sign the HTTP request using sigv4 (https://github.com/aws/amazon-neptune-gremlin-java-sigv4/blob/master/src/main/java/org/apache/tinkerpop/gremlin/driver/SigV4WebSocketChannelizer.java) 

      This ticket proposes to allow WebSocketChannelizer to be extended.

      Attachments

        Activity

          People

            Unassigned Unassigned
            divijvaidya Divij Vaidya
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: