Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2427

Simplify Netty reference counting

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.5.0, 3.4.8
    • 3.5.0, 3.4.9
    • driver
    • None

    Description

      We have some incorrect configuration in the code such as:
      https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketGremlinResponseDecoder.java#L59 (MessageToMessageDecoder automatically decreases the reference count).

      https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java#L270 (SimpleChannelInboundHandler automatically decreases the reference count).

      which are fixed by hardcoding values such as:
      https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketClientHandler.java#L89

      This Jira will fix the reference counting correctly and eliminate the need for hardcoding.

      Attachments

        Activity

          People

            Unassigned Unassigned
            divijvaidya Divij Vaidya
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: