Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2427

Simplify Netty reference counting

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.0, 3.4.8
    • Fix Version/s: 3.5.0, 3.4.9
    • Component/s: driver
    • Labels:
      None

      Description

      We have some incorrect configuration in the code such as:
      https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketGremlinResponseDecoder.java#L59 (MessageToMessageDecoder automatically decreases the reference count).

      https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java#L270 (SimpleChannelInboundHandler automatically decreases the reference count).

      which are fixed by hardcoding values such as:
      https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketClientHandler.java#L89

      This Jira will fix the reference counting correctly and eliminate the need for hardcoding.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              divijvaidya Divij Vaidya

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment