Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Invalid
-
3.4.1
-
None
-
None
Description
While trying to update JanusGraph to TinkerPop 3.4.0, I encountered two issues with the ShortestPathVertexProgramm:
- ShortestPathVertexProgram.getMessageScopes() returns an empty collection which doesn't work for a graph computer that uses these scopes to execute the edge traversal. I think the scopes should be Global and Local with the edge traversal.
- The ShortestPathVertexProgram defines no message combiner, but sendMessages() can apparently still send multiple messages for the same vertex.
For some reason, this doesn't lead to any problems for the TinkerGraphComputer. (Maybe it receives each message before another one can be sent for the same vertex?)
For FulgoraGraphComputer however some tests result in a situation where multiple messages are sent to the same vertex which fails because no combiner is defined.
So, I'd say that the ShortestPathVertexProgram should have a message combiner.