[TINKERPOP-2173] Incorrect reset of log level in integration test

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.3.6, 3.4.1
• Component/s: server
• Assignee: Stephen Mallette
• Reporter: Divij Vaidya
• Created: 08/Mar/19 03:06
• Updated: 14/Mar/19 13:08
• Resolved: 14/Mar/19 13:08

Description

This issue is regarding GremlinServerIntegrateTest.java and other similar tests.

In the @After method, the intention is to reset the log level which was temporarily changed in the @Before method for the duration of the test. However, instead of resetting to the original state, the code ends up setting the same log level again.

Proposed fix:
Do not mutate the previousLogLevel field in the @After methods [1][2]

[1]https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java#L149
[2]https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java#L124