Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2130

Cannot instantiate DriverRemoteConnection without passing an options object

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.0, 3.3.5
    • Fix Version/s: 3.3.6, 3.4.1
    • Component/s: javascript
    • Labels:
      None

      Description

      In gremlin-javascript, when instantiating a new DriverRemoteConnection without passing an options object, a TypeError is thrown. This is a breaking change introduced in v3.4.0.

      For example:

      const dc = new DriverRemoteConnection(process.env.GRAPH_URL);

      The above code results in an error being thrown:

      TypeError: Cannot read property 'reader' of undefined

      This works fine:

      const dc = new DriverRemoteConnection(process.env.GRAPH_URL, {});

      Both calls work correctly when using 3.3.4. 

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                nivsherf Niv Sherf
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: