Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2028

AbstractGraphSONMessageSerializerV2d0 should register GremlinServerModule when mapper is provided

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.3.1, 3.2.9
    • 3.4.0
    • io
    • None

    Description

      When specifying a GraphSONMapper when constructing a GraphSONMessageSerializerV3d0, the Message serializer will not register any module. Hence users will have to manually register the GremlinServerModule to the GraphSONMapper they are giving in parameter for it to work at all:

      GraphSONMessageSerializerV3d0 messageSerializerV3d0 =
          new GraphSONMessageSerializerV3d0(
              GraphSONMapper.build()
                  .version(GraphSONVersion.V3_0)
                  .addCustomModule(new 
      AbstractGraphSONMessageSerializerV2d0.GremlinServerModule())
                  .addRegistry(TinkerIoRegistryV3d0.instance()).create());
      

      When not providing a Mapper, the GremlinServerModule is registered automatically. It sounds reasonable in the context of the GraphSONMessageSerializer to automatically register the GremlinServerModule wdyt?

      Attachments

        Issue Links

          Activity

            People

              spmallette Stephen Mallette
              newkek Kevin Gallardo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: