Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1978

Check for Websocket connection state when retrieved from Connection Pool missing

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.4.0, 3.3.4, 3.2.10
    • Component/s: dotnet
    • Labels:
      None

      Description

      When retrieving a connection from the connection pool there is no check to see what the current connection state of the websocket is before it is used.  This means that if the websocket were to be closed because the server recycled or the connection was aborted by the server since it was last used and its Send method were to be called the following exception would be thrown:

      Error during execution ExecuteJObjectQueryAsync method. Exception: System.Net.Http.WinHttpException (0x80072EFF): The connection with the server was terminated abnormally

      at System.Net.WebSockets.WinHttpWebSocket.SendAsync(ArraySegment`1 buffer, WebSocketMessageType messageType, Boolean endOfMessage, CancellationToken cancellationToken)

      at System.Net.WebSockets.WebSocketHandle.SendAsync(ArraySegment`1 buffer, WebSocketMessageType messageType, Boolean endOfMessage, CancellationToken cancellationToken)

      at Gremlin.Net.Driver.WebSocketConnection.<SendMessageAsync>d__5.MoveNext()

       

      Please add check the Websocket state before use, handle exceptions due to closed or aborted connections and ideally have an extensible retry handler.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Florian Hockmann Florian Hockmann
                Reporter:
                jamilu Jamilu Abubakar
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: