Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1830

Race condition in Tinkergraph index creation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.0, 3.2.6
    • Fix Version/s: 3.2.7, 3.3.1
    • Component/s: tinkergraph
    • Labels:
      None

      Description

      My colleage Fabian Yamaguchi <fabs@shiftleft.io> discovered a race condition in tinkergraph's index creation. He fixed it by simply replacing `parallelStream` with `stream`. Quoting his analysis:

      > So, reading the code, you see that this.put is called in parallel, but that method seems to contain a race as get is called on the index, checked for null, and a subsequent write is performed. It still seems like using stream here fixes the problem we've been seeing, and the performance hit is not significant.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mpollmeier Michael Pollmeier
                Reporter:
                mpollmeier Michael Pollmeier
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: