Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.2.5
    • Fix Version/s: 3.3.0
    • Component/s: io
    • Labels:
      None

      Description

      Introduce Gryo 3.0. Better separation of domain objects from serialization format for graph elements. Dynamic serializer registrations to include those from gremlin-driver.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user spmallette opened a pull request:

          https://github.com/apache/tinkerpop/pull/645

          TINKERPOP-1698 Gryo 3.0

          https://issues.apache.org/jira/browse/TINKERPOP-1698

          Gryo 3.0 is in place. A good bunch of the changes just had to do with adding more tests to cover 3.0 and 1.0. For 3.3.0 Gryo 3.0 will be the default. Users can easily switch back to 1.0 through various configuration options. Gryo 3.0 isn't really compatible with 1.0 - there may be partial compatibility here and there.

          Full builds with docker work nicely.

          VOTE +1

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/tinkerpop TINKERPOP-1698

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tinkerpop/pull/645.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #645


          commit 69565d476b44e86cd99803507e5359d6ced1da5c
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-22T23:01:05Z

          TINKERPOP-1698 Gryo 3.0 WIP

          commit b599980566d44a7dda997263c29b2a71e1e5fde5
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-24T13:55:20Z

          TINKERPOP-1698 Metrics serializer for gryo 3.0 and abstract ClassResolver

          commit cc22b7136f7e6603cbc31902f02b113a75a4ced0
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-26T13:03:13Z

          TINKERPOP-1698 Fixed up a bunch of tests with Gryo V3

          Basically had to default everything to work on V3. Might need to change up some tests to validate V1 specifically still.

          commit 045eb052fb07d553cef15d455b14595ca6fa8327
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-26T15:19:29Z

          TINKERPOP-1698 Refactored gryo serialization tests

          Did a better job parameterizing tests for re-use.

          commit 9bf1caf15c06ef4408dd7750fab5327cbc570f6b
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-26T15:28:29Z

          TINKERPOP-1698 Folded Gryo lite tests into main gryo tests

          commit 80e08f52e056b62ff40161160da8b41b94bbf44c
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-26T17:23:55Z

          TINKERPOP-1698 Hooked up Gryo 3.0 for OLAP stuff.

          Improved configurability for the version. Parameterized tests for 1.0 and 3.0.

          commit 07c97aafd404d38ae7d3621b4f17ac987a806567
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-26T19:41:38Z

          TINKERPOP-1698 Initialize computedMetrics

          Without that initialization there are scenarios in sparkgraphcomputer where serialization will fail. The Gryo 3.0 TraversalMetricSerializer gets a collection of computed metrics and null pointers basically.

          commit b52842199a9a567ee8c60d9d2aa42ac29e4b59d6
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-27T11:42:07Z

          TINKERPOP-1698 Include traversal index in deserialization

          Seems like it is needed for giraph for some reason.

          commit 616a92a7071009e39297ec6215ed92ef5e873953
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-27T12:46:35Z

          TINKERPOP-1698 Changed format of property writes

          Write properties with streams instead of pulling them into a List in memory

          commit 82a35372da392927c9665653d5b3ad70c2394161
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-29T14:18:38Z

          TINKERPOP-1698 Added Gryo v3 to all configs

          Removed v1 where necessary - don't really want to promote that version anymore.

          commit 8fb6d63ecb14446de74be25f0bdd8d37feabfe72
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-29T14:28:44Z

          TINKERPOP-1698 Cleaned up docs with old serializer output in them

          commit f911c009d74c32df636604f57783fdd09ca2c37f
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-29T15:14:10Z

          TINKERPOP-1698 Cleaned up comments

          commit 18fd172f1ec45ca09dbe7a349d47db236ee61a87
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-29T15:21:36Z

          TINKERPOP-1698 Update the upgrade docs for gryo 3.0


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/645 TINKERPOP-1698 Gryo 3.0 https://issues.apache.org/jira/browse/TINKERPOP-1698 Gryo 3.0 is in place. A good bunch of the changes just had to do with adding more tests to cover 3.0 and 1.0. For 3.3.0 Gryo 3.0 will be the default. Users can easily switch back to 1.0 through various configuration options. Gryo 3.0 isn't really compatible with 1.0 - there may be partial compatibility here and there. Full builds with docker work nicely. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1698 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/645.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #645 commit 69565d476b44e86cd99803507e5359d6ced1da5c Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-22T23:01:05Z TINKERPOP-1698 Gryo 3.0 WIP commit b599980566d44a7dda997263c29b2a71e1e5fde5 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-24T13:55:20Z TINKERPOP-1698 Metrics serializer for gryo 3.0 and abstract ClassResolver commit cc22b7136f7e6603cbc31902f02b113a75a4ced0 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-26T13:03:13Z TINKERPOP-1698 Fixed up a bunch of tests with Gryo V3 Basically had to default everything to work on V3. Might need to change up some tests to validate V1 specifically still. commit 045eb052fb07d553cef15d455b14595ca6fa8327 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-26T15:19:29Z TINKERPOP-1698 Refactored gryo serialization tests Did a better job parameterizing tests for re-use. commit 9bf1caf15c06ef4408dd7750fab5327cbc570f6b Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-26T15:28:29Z TINKERPOP-1698 Folded Gryo lite tests into main gryo tests commit 80e08f52e056b62ff40161160da8b41b94bbf44c Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-26T17:23:55Z TINKERPOP-1698 Hooked up Gryo 3.0 for OLAP stuff. Improved configurability for the version. Parameterized tests for 1.0 and 3.0. commit 07c97aafd404d38ae7d3621b4f17ac987a806567 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-26T19:41:38Z TINKERPOP-1698 Initialize computedMetrics Without that initialization there are scenarios in sparkgraphcomputer where serialization will fail. The Gryo 3.0 TraversalMetricSerializer gets a collection of computed metrics and null pointers basically. commit b52842199a9a567ee8c60d9d2aa42ac29e4b59d6 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-27T11:42:07Z TINKERPOP-1698 Include traversal index in deserialization Seems like it is needed for giraph for some reason. commit 616a92a7071009e39297ec6215ed92ef5e873953 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-27T12:46:35Z TINKERPOP-1698 Changed format of property writes Write properties with streams instead of pulling them into a List in memory commit 82a35372da392927c9665653d5b3ad70c2394161 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-29T14:18:38Z TINKERPOP-1698 Added Gryo v3 to all configs Removed v1 where necessary - don't really want to promote that version anymore. commit 8fb6d63ecb14446de74be25f0bdd8d37feabfe72 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-29T14:28:44Z TINKERPOP-1698 Cleaned up docs with old serializer output in them commit f911c009d74c32df636604f57783fdd09ca2c37f Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-29T15:14:10Z TINKERPOP-1698 Cleaned up comments commit 18fd172f1ec45ca09dbe7a349d47db236ee61a87 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-29T15:21:36Z TINKERPOP-1698 Update the upgrade docs for gryo 3.0
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user okram commented on the issue:

          https://github.com/apache/tinkerpop/pull/645

          VOTE +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/645 VOTE +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dkuppitz commented on the issue:

          https://github.com/apache/tinkerpop/pull/645

          `docker/build.sh -t -i` succeeded.

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/645 `docker/build.sh -t -i` succeeded. VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/645

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/645

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              spmallette stephen mallette
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development