Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1663

Validate a maximum for the number of parameters passed to Gremlin Server

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: 3.2.4
    • Fix Version/s: 3.2.5
    • Component/s: server
    • Labels:
      None

      Description

      Given that tests have shown that scripts with very large number of parameters take a longer amount of time to compile than scripts with smaller numbers of parameters, having some control over the number of allowed parameters might help prevent users from falling into an anti-pattern.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user spmallette opened a pull request:

          https://github.com/apache/tinkerpop/pull/591

          TINKERPOP-1663 Validation for maximum number of parameters on a request

          https://issues.apache.org/jira/browse/TINKERPOP-1663

          Provides a configuration option to validate the number of parameters that gremlin server will accept on a request for script evaluation.

          Ran integration tests for gremlin-server and console.

          vOTE +1

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/tinkerpop TINKERPOP-1663

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tinkerpop/pull/591.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #591


          commit a4c652ae3c071c15c5a57524a797707f5ea318a4
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-04-03T11:04:42Z

          TINKERPOP-1663 Validation for maximum number of parameters on a request

          The default is set to 16 and there is a configuration option to allow it to be changed.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/591 TINKERPOP-1663 Validation for maximum number of parameters on a request https://issues.apache.org/jira/browse/TINKERPOP-1663 Provides a configuration option to validate the number of parameters that gremlin server will accept on a request for script evaluation. Ran integration tests for gremlin-server and console. vOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1663 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/591.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #591 commit a4c652ae3c071c15c5a57524a797707f5ea318a4 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-04-03T11:04:42Z TINKERPOP-1663 Validation for maximum number of parameters on a request The default is set to 16 and there is a configuration option to allow it to be changed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user twilmes commented on the issue:

          https://github.com/apache/tinkerpop/pull/591

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user twilmes commented on the issue: https://github.com/apache/tinkerpop/pull/591 VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user davebshow commented on the issue:

          https://github.com/apache/tinkerpop/pull/591

          LGTM. Also ran server/console integration. Docs are clear.

          VOTE +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/591 LGTM. Also ran server/console integration. Docs are clear. VOTE +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/591

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/591

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              spmallette stephen mallette
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development