Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.2.3
    • Fix Version/s: 3.3.0
    • Component/s: io
    • Labels:
      None

      Description

      We should not have GraphSON 2.0 untyped. Too many degrees of freedom. GraphSON should be GraphSON typed and thats that.

        Issue Links

          Activity

          Hide
          spmallette stephen mallette added a comment -

          This will be completed as part of TINKERPOP-1565

          Show
          spmallette stephen mallette added a comment - This will be completed as part of TINKERPOP-1565
          Hide
          spmallette stephen mallette added a comment -

          GraphSON 2.0 won't change its format so as to not create a breaking change. This will happen for 3.0.

          Show
          spmallette stephen mallette added a comment - GraphSON 2.0 won't change its format so as to not create a breaking change. This will happen for 3.0.
          Hide
          dkuppitz Daniel Kuppitz added a comment -

          A specific problem popped up recently: I was using constant(Collections.emptySet()) in a traversal which was causing errors, because the serialized Set was deserialized as a List (for untyped GraphSON all implementations of Collection look the same and thus every Collection is considered to be a List). A workaround has been added in this commit: https://github.com/apache/tinkerpop/commit/69b314cb2e52f33dbab29d3cddaadacb4ec69099
          I think, once the GraphSON issue is fixed, the workaround should be reverted as it seems to be a good extra test case.

          Show
          dkuppitz Daniel Kuppitz added a comment - A specific problem popped up recently: I was using constant(Collections.emptySet()) in a traversal which was causing errors, because the serialized Set was deserialized as a List (for untyped GraphSON all implementations of Collection look the same and thus every Collection is considered to be a List ). A workaround has been added in this commit: https://github.com/apache/tinkerpop/commit/69b314cb2e52f33dbab29d3cddaadacb4ec69099 I think, once the GraphSON issue is fixed, the workaround should be reverted as it seems to be a good extra test case.

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              okram Marko A. Rodriguez
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development