Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.1.0
    • Component/s: tiles-core
    • Labels:
      None
    • Environment:

      Platform independent

      Description

      There should be support for nested definitions, i.e. definitions in which one or more attributes are assigned directly a definition, instead of a reference of a "named" one. For instance:

      <definition name="tileB" extends="tileA">
      <put name="header">
      <definition path="/header.jsp">
      <put name="menu" value="/menu.jsp" />
      </definition>
      </put>
      <put name="body" value="/body.jsp" />
      </definition>

      The nested definition has not a name, because it does not need it and it will be used only in the outer definition.

      1. tiles-patch.diff
        5 kB
        Antonio Petrelli
      2. tiles-patch-2006-09-14.zip
        4 kB
        Antonio Petrelli

        Issue Links

          Activity

          Antonio Petrelli created issue -
          Hide
          Antonio Petrelli added a comment -

          This patch depends on the patch posted in the issue:
          http://issues.apache.org/struts/browse/SB-27

          I modified only "resolveAttributeDependencies()" method of ComponentDefinitionsImpl and not the "resolveAttributeDependencies(Locale locale)" method because it has been submitted as a patch in another issue:
          http://issues.apache.org/struts/browse/SB-26

          Show
          Antonio Petrelli added a comment - This patch depends on the patch posted in the issue: http://issues.apache.org/struts/browse/SB-27 I modified only "resolveAttributeDependencies()" method of ComponentDefinitionsImpl and not the "resolveAttributeDependencies(Locale locale)" method because it has been submitted as a patch in another issue: http://issues.apache.org/struts/browse/SB-26
          Antonio Petrelli made changes -
          Field Original Value New Value
          Attachment tiles-patch.diff [ 13070 ]
          Mehdi Bahribayli made changes -
          Link This issue relates to SB-40 [ SB-40 ]
          Hide
          Antonio Petrelli added a comment -

          In addition to what I wrote before, <tiles:put> and <tiles:definition> should follow the same guidelines, i.e. it should be possible to do:

          <tiles:definition name="tileB" extends="tileA">
          <tiles:put name="header">
          <tiles:definition template="/header.jsp">
          <tiles:put name="menu" value="/menu.jsp" />
          </tiles:definition>
          </tiles:put>
          <tiles:put name="body" value="/body.jsp" />
          </tiles:definition>

          Show
          Antonio Petrelli added a comment - In addition to what I wrote before, <tiles:put> and <tiles:definition> should follow the same guidelines, i.e. it should be possible to do: <tiles:definition name="tileB" extends="tileA"> <tiles:put name="header"> <tiles:definition template="/header.jsp"> <tiles:put name="menu" value="/menu.jsp" /> </tiles:definition> </tiles:put> <tiles:put name="body" value="/body.jsp" /> </tiles:definition>
          Hide
          Antonio Petrelli added a comment -

          I attached a patch instead of committing because I would like to know if it is ok for everyone

          Show
          Antonio Petrelli added a comment - I attached a patch instead of committing because I would like to know if it is ok for everyone
          Antonio Petrelli made changes -
          Attachment tiles-patch-2006-09-14.zip [ 13147 ]
          Hide
          David DeWolf added a comment -

          Feature request that can be done after 2.0.0 alpha

          Show
          David DeWolf added a comment - Feature request that can be done after 2.0.0 alpha
          David DeWolf made changes -
          Fix Version/s 2.0.1 [ 21770 ]
          Antonio Petrelli made changes -
          Affects Version/s 2.0 [ 21730 ]
          Component/s core [ 21321 ]
          Affects Version/s 2.0.0 [ 21781 ]
          Key SB-29 TILES-85
          Workflow jira [ 38465 ] Struts [ 40884 ]
          Fix Version/s 2.0.x [ 21782 ]
          Project Sandbox [ 10122 ] Tiles [ 10160 ]
          Component/s Tiles [ 21260 ]
          Fix Version/s 2.0.1 [ 21770 ]
          Antonio Petrelli made changes -
          Fix Version/s 2.1.x [ 21820 ]
          Fix Version/s 2.0.x [ 21782 ]
          Jeff Turner made changes -
          Workflow Struts [ 40884 ] Struts - editable closed status [ 42565 ]
          Antonio Petrelli made changes -
          Priority Trivial [ 5 ] Major [ 3 ]
          Antonio Petrelli made changes -
          Assignee Antonio Petrelli [ brenmcguire ]
          Hide
          Antonio Petrelli added a comment -

          Added support to nested definitions.

          Show
          Antonio Petrelli added a comment - Added support to nested definitions.
          Antonio Petrelli made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 2.1.0 [ 21831 ]
          Fix Version/s 2.1.x [ 21820 ]
          Antonio Petrelli made changes -
          Link This issue is duplicated by TILES-214 [ TILES-214 ]
          Antonio Petrelli made changes -
          Flags [Patch]
          Hide
          Antonio Petrelli added a comment -

          Closed due to the release of Tiles 2.1.0.

          Show
          Antonio Petrelli added a comment - Closed due to the release of Tiles 2.1.0.
          Antonio Petrelli made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Antonio Petrelli made changes -
          Workflow Struts - editable closed status [ 42565 ] Struts - editable closed status (temporary) [ 45584 ]
          Antonio Petrelli made changes -
          Workflow Struts - editable closed status (temporary) [ 45584 ] Struts - editable closed status [ 49327 ]
          Antonio Petrelli made changes -
          Workflow Struts - editable closed status [ 49327 ] Simplified [ 53118 ]
          Jeff Turner made changes -
          Project Import Mon Feb 01 01:30:28 UTC 2010 [ 1264987828110 ]

            People

            • Assignee:
              Antonio Petrelli
              Reporter:
              Antonio Petrelli
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development