Tiles
  1. Tiles
  2. TILES-65

Split <tiles:insert> into specialized tags

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Component/s: tiles-core
    • Labels:
      None
    • Environment:

      N/A (design issue)

      Description

      The <tiles:insert> tag can lead to confusion because it can insert different things: pages, strings, definitions and attribute.
      There is a particular confusion for the attribute, since some people could place it as they place definitions and pages, not remembering that attributes need to be filled.

      <tiles:insert> could be split into:

      <tiles:insertDefinition>
      <tiles:insertTemplate>
      <tiles:insertString> (not sure about it).
      <tiles:attribute>: it has a different name pattern because attributes need to be "defined" and not "inserted".

      Relevant thread:
      http://www.mail-archive.com/dev%40struts.apache.org/msg24891.html

      And the message:
      http://www.mail-archive.com/user%40shale.apache.org/msg00663.html

        Issue Links

          Activity

          Gavin made changes -
          Link This issue is depended upon by TILES-73 [ TILES-73 ]
          Gavin made changes -
          Link This issue blocks TILES-73 [ TILES-73 ]
          Jeff Turner made changes -
          Project Import Mon Feb 01 01:30:28 UTC 2010 [ 1264987828110 ]
          Antonio Petrelli made changes -
          Workflow Struts - editable closed status [ 49473 ] Simplified [ 53134 ]
          Antonio Petrelli made changes -
          Workflow Struts - editable closed status (temporary) [ 45751 ] Struts - editable closed status [ 49473 ]
          Antonio Petrelli made changes -
          Workflow Struts - editable closed status [ 42872 ] Struts - editable closed status (temporary) [ 45751 ]
          Jeff Turner made changes -
          Workflow Struts [ 40864 ] Struts - editable closed status [ 42872 ]
          Antonio Petrelli made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Antonio Petrelli made changes -
          Affects Version/s 2.0 [ 21730 ]
          Fix Version/s 2.0.0 [ 21781 ]
          Affects Version/s 2.0.0 [ 21781 ]
          Component/s Tiles [ 21260 ]
          Key SB-55 TILES-65
          Component/s core [ 21321 ]
          Workflow jira [ 38819 ] Struts [ 40864 ]
          Project Sandbox [ 10122 ] Tiles [ 10160 ]
          Fix Version/s 2.0 [ 21730 ]
          Antonio Petrelli made changes -
          Link This issue blocks SB-21 [ SB-21 ]
          Antonio Petrelli made changes -
          Link This issue is related to SB-46 [ SB-46 ]
          Antonio Petrelli made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Fix Version/s 2.0 [ 21730 ]
          Hide
          Antonio Petrelli added a comment -

          InsertTag has been splitted into three tags:
          InsertDefinitionTag, to insert definitions;
          InsertTemplateTag, to insert templates;
          AttributeTag, to insert (I should say "define") attributes.
          There was no need to create a <tiles:insertString> tag, since there are better tag libraries to put strings.
          Modified tiles-core.tld accordingly and added a FAQ entry for the change.

          Show
          Antonio Petrelli added a comment - InsertTag has been splitted into three tags: InsertDefinitionTag, to insert definitions; InsertTemplateTag, to insert templates; AttributeTag, to insert (I should say "define") attributes. There was no need to create a <tiles:insertString> tag, since there are better tag libraries to put strings. Modified tiles-core.tld accordingly and added a FAQ entry for the change.
          Antonio Petrelli committed 468346 (1 file)
          Reviews: none
          Old issue: SB-55

          SB-55
          Added FAQ entry for the removal of <tiles:insert> tag.

          Antonio Petrelli made changes -
          Field Original Value New Value
          Assignee Antonio Petrelli [ brenmcguire ]
          Antonio Petrelli created issue -

            People

            • Assignee:
              Antonio Petrelli
              Reporter:
              Antonio Petrelli
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development