Tiles
  1. Tiles
  2. TILES-542

Inject VelocityEngine into VelocityAttributeRenderer

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.2.2
    • Fix Version/s: None
    • Component/s: tiles-velocity
    • Labels:
      None

      Description

      VelocityAttributeRenderer instantiates VelocityView, which in turn instantiates its own VelocityEngine. There is no way to inject a customized VelocityEngine from outside except for extending VelocityAttributeRenderer and overriding commit().

      There should be an API for passing customized VelocityEngine to the view.

        Activity

        Hide
        Mck SembWever added a comment -

        New development isn't planned for tiles-2.2
        If this issue is still valid against tiles-3.0 (specifically tiles-request-velocity and tiles-velocity) then we would be interested in reviewing a patch.

        Show
        Mck SembWever added a comment - New development isn't planned for tiles-2.2 If this issue is still valid against tiles-3.0 (specifically tiles-request-velocity and tiles-velocity) then we would be interested in reviewing a patch.
        Hide
        Konrad Garus added a comment -

        The VelocityAttributeRenderer.params map on supports String values, so it is unsuitable. It could be solved by making this Map<String, Object> and adding a parameter for the custom engine, or by adding a VelocityEngine field to VelocityAttributeRenderer and passing it to the view in commit().

        If this is confirmed and desired extension, I could submit a patch.

        Show
        Konrad Garus added a comment - The VelocityAttributeRenderer.params map on supports String values, so it is unsuitable. It could be solved by making this Map<String, Object> and adding a parameter for the custom engine, or by adding a VelocityEngine field to VelocityAttributeRenderer and passing it to the view in commit(). If this is confirmed and desired extension, I could submit a patch.
        Konrad Garus created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Konrad Garus
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development