Tiles
  1. Tiles
  2. TILES-516

JSP exceptions are hidden by Tiles making debugging difficult

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Incomplete
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      When using tiles:insertDefinition, any exceptions thrown by the jsp renderer are being hidden from the logs by TilesContainer.

      Based upon apache's logging best practices(http://commons.apache.org/logging/guide.html), I believe it would be best if exceptions caught in TilesContainer's render methods were logged before being rethrown.

      "External Boundaries - Expected Exceptions. This classification includes exceptions such as FileNotFoundException that cross API/SPI boundaries, and are exposed to the user of a component/toolkit. These are listed in the 'throws' clause of a method signature.
      Appropriate handling of these exceptions depends upon the type of code you are developing. API's for utility functions and tools should log these at the debug level, if they are caught at all by internal code.
      For higher level frameworks and middleware components, these exceptions should be caught immediatly prior to crossing the API/SPI interface back to user code-space, logged with full stack trace at info level, and rethrown. The assures that the log contains a record of the root cause for future analysis in the event that the exception is not caught and resolved as expected by the user's code. "

        Activity

        Antonio Petrelli made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Incomplete [ 4 ]
        Clayton Rabenda created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Clayton Rabenda
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development