Tiles
  1. Tiles
  2. TILES-374

change visibility of 'render' methods in BasicTilesContainer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.1.3
    • Component/s: tiles-core
    • Labels:
      None

      Description

      Extending BasicTilesContainer is limited due to many private methods. I'd like to add declarative caching in my tiles definition file (by adding an attribute 'cache' with value 'cacheKey') to skip rendering of a definition and pull entire content from the cache. Actually the only place I can do that is BasicTilesContainer.render(TilesRequestContext request, String definitionName) method. Within this method, definition is being loaded (hence, attributes are available) and check against possible cache would be possible. Unfortunately this and following 'render' methods are private, and I can't override appropriate methods. Can you consider changing visibility to protected or providing some hooks in definition rendering flow.

        Activity

        pijmleko created issue -
        pijmleko made changes -
        Field Original Value New Value
        Affects Version/s 2.1.2 [ 21904 ]
        pijmleko made changes -
        Attachment TILES-374.patch [ 13974 ]
        Antonio Petrelli made changes -
        Assignee Antonio Petrelli [ brenmcguire ]
        Antonio Petrelli made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 2.1.3 [ 21910 ]
        Status Open [ 1 ] Closed [ 6 ]
        Jeff Turner made changes -
        Project Import Mon Feb 01 01:30:28 UTC 2010 [ 1264987828110 ]

          People

          • Assignee:
            Antonio Petrelli
            Reporter:
            pijmleko
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development