Tiles
  1. Tiles
  2. TILES-374

change visibility of 'render' methods in BasicTilesContainer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.1.3
    • Component/s: tiles-core
    • Labels:
      None

      Description

      Extending BasicTilesContainer is limited due to many private methods. I'd like to add declarative caching in my tiles definition file (by adding an attribute 'cache' with value 'cacheKey') to skip rendering of a definition and pull entire content from the cache. Actually the only place I can do that is BasicTilesContainer.render(TilesRequestContext request, String definitionName) method. Within this method, definition is being loaded (hence, attributes are available) and check against possible cache would be possible. Unfortunately this and following 'render' methods are private, and I can't override appropriate methods. Can you consider changing visibility to protected or providing some hooks in definition rendering flow.

        Activity

        Hide
        Antonio Petrelli added a comment -

        I agree. Can you post a patch? Do it against the trunk, please.

        Show
        Antonio Petrelli added a comment - I agree. Can you post a patch? Do it against the trunk, please.
        Hide
        pijmleko added a comment - - edited

        patch added (more extensible definition rendering flow in BasicTilesContainer)

        Show
        pijmleko added a comment - - edited patch added (more extensible definition rendering flow in BasicTilesContainer)
        Hide
        Antonio Petrelli added a comment -

        Good idea to extract the render(request, definition) method.

        Show
        Antonio Petrelli added a comment - Good idea to extract the render(request, definition) method.
        Hide
        Antonio Petrelli added a comment -

        Patch applied to trunk and TILES_2_1_X branch, thanks!

        Show
        Antonio Petrelli added a comment - Patch applied to trunk and TILES_2_1_X branch, thanks!

          People

          • Assignee:
            Antonio Petrelli
            Reporter:
            pijmleko
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development