[TILES-134] NullPointer Exception when tiles servlet is not defined

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.2
• Fix Version/s: 2.0.2
• Component/s: tiles-jsp (jsp support)

Environment

Tomcat 5.5.20, jre1.5_06

• Flags: Patch
• Assignee: Antonio Petrelli
• Reporter: Scot Meyer
• Created: 07/Mar/07 18:15
• Updated: 02/May/13 02:28
• Resolved: 09/Mar/07 10:05

Description

When implementing a simple template and the tiles servlet is not defined in the web.xml you get a NullPointer exception at line 144 when running. This can be difficult for the implementer to realize what they did wrong. A suggestion would be to throw and exception when the context is null. It might be better to throw a TilesException however the interface defines a JspException so I used it.

— RenderTagSupport.java 2007-03-05 16:53:50.000000000 -0500
+++ tiles-jsp/src/main/java/org/apache/tiles/jsp/taglib/RenderTagSupport.java 2007-03-05 16:52:49.000000000 -0500
@@ -136,13 +136,11 @@
*

• @param nestedTag the put tag desciendent.
  */

• public void processNestedTag(PutAttributeTag nestedTag) throws JspException {
  + public void processNestedTag(PutAttributeTag nestedTag) {
  ComponentAttribute attribute = new ComponentAttribute(
  nestedTag.getValue(), nestedTag.getRole(),
  nestedTag.getType());

• if (componentContext==null) throw new JspException("componentContext is null. Do you have the org.apache.tiles.servlet.TilesServlet defined in the web.xml?");
  -
  componentContext.putAttribute(
  nestedTag.getName(),
  attribute
  ~

Issue Links

• depends upon: TILES-135 Attribute tags do not need container