Uploaded image for project: 'Tika'
  1. Tika
  2. TIKA-901

Provide version number in tika-server

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.2
    • Component/s: server
    • Labels:
      None

      Description

      Tika server currently does not provide its version number.

      1. TIKA-901.diff
        7 kB
        Ingo Renner
      2. TIKA-901.diff
        4 kB
        Ingo Renner
      3. TikaVersionTest.java
        3 kB
        Ingo Renner

        Activity

        Hide
        ingorenner Ingo Renner added a comment -

        While implementing this I also had the issue that when launching Tika Server it seems it was intended to print the version number but fails to read the property.

        Since the version number is provided by the Tika class's toString() method... Wouldn't it make sense to use that at startup, too? This way we don't need to read properties from tikaserver-version.properties and can drop that too of course.

        Show
        ingorenner Ingo Renner added a comment - While implementing this I also had the issue that when launching Tika Server it seems it was intended to print the version number but fails to read the property. Since the version number is provided by the Tika class's toString() method... Wouldn't it make sense to use that at startup, too? This way we don't need to read properties from tikaserver-version.properties and can drop that too of course.
        Hide
        chrismattmann Chris A. Mattmann added a comment -

        Hey Ingo, thanks for this. How about a unit test similar to our other Junit tests for end points. If you don't get a chance to do it, I'll provide one before I commit this. Thanks I will check it out.

        Show
        chrismattmann Chris A. Mattmann added a comment - Hey Ingo, thanks for this. How about a unit test similar to our other Junit tests for end points. If you don't get a chance to do it, I'll provide one before I commit this. Thanks I will check it out.
        Hide
        ingorenner Ingo Renner added a comment -

        I'll try to provide a test.

        Show
        ingorenner Ingo Renner added a comment - I'll try to provide a test.
        Hide
        chrismattmann Chris A. Mattmann added a comment -

        Thanks Ingo. It could be super simple and just test that the output of calling /version prints Tika.getClass().toString() or whatever. Check out the other test cases to get an idea of how to quickly run one.

        Show
        chrismattmann Chris A. Mattmann added a comment - Thanks Ingo. It could be super simple and just test that the output of calling /version prints Tika.getClass().toString() or whatever. Check out the other test cases to get an idea of how to quickly run one.
        Hide
        ingorenner Ingo Renner added a comment -

        Hi Chris, here's the test.

        Show
        ingorenner Ingo Renner added a comment - Hi Chris, here's the test.
        Hide
        chrismattmann Chris A. Mattmann added a comment -

        Thanks a ton Ingo. I will start on this.

        One quick comment. If you are adding a file, I still prefer including it as part of your TIKA patch. The way to do this in general is to:

        1. svn add /path/to/your/new/file
        2. svn status (make sure that it shows your changes and added files)
        3. svn diff > TIKA-xxx.<username>.<yyMMdd>.patch.txt

        Not a big deal but just letting ya know' Thanks dude. I will work on this hopefully later today.

        Show
        chrismattmann Chris A. Mattmann added a comment - Thanks a ton Ingo. I will start on this. One quick comment. If you are adding a file, I still prefer including it as part of your TIKA patch. The way to do this in general is to: svn add /path/to/your/new/file svn status (make sure that it shows your changes and added files) svn diff > TIKA-xxx.<username>.<yyMMdd>.patch.txt Not a big deal but just letting ya know' Thanks dude. I will work on this hopefully later today.
        Hide
        ingorenner Ingo Renner added a comment -

        Please excuse my moment of laziness

        Show
        ingorenner Ingo Renner added a comment - Please excuse my moment of laziness
        Hide
        chrismattmann Chris A. Mattmann added a comment -

        haha no worries – wasn't sure if it was lazy or just not having done it before so wanted to make sure.

        Show
        chrismattmann Chris A. Mattmann added a comment - haha no worries – wasn't sure if it was lazy or just not having done it before so wanted to make sure.
        Hide
        ingorenner Ingo Renner added a comment -

        yeah, no worries - really just a lazy moment and close to leaving the office

        Show
        ingorenner Ingo Renner added a comment - yeah, no worries - really just a lazy moment and close to leaving the office
        Hide
        chrismattmann Chris A. Mattmann added a comment -

        Committed in r1331147, thanks Ingo YOU ROCK!

        Show
        chrismattmann Chris A. Mattmann added a comment - Committed in r1331147, thanks Ingo YOU ROCK!
        Hide
        ingorenner Ingo Renner added a comment -

        Thanks Chris for rocking even more. I'm just taking small steps, one at a time

        Show
        ingorenner Ingo Renner added a comment - Thanks Chris for rocking even more. I'm just taking small steps, one at a time

          People

          • Assignee:
            chrismattmann Chris A. Mattmann
            Reporter:
            ingorenner Ingo Renner
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development