Uploaded image for project: 'Tika'
  1. Tika
  2. TIKA-375 Improve code quality metrics
  3. TIKA-838

EmptyParser Singleton should be final

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.1
    • general
    • None

    Description

      Currently the Singleton EmptyParser is not a robust singleton. Other Code could possibly exchange it, as it is not marked final.
      This might pose a security risk.
      Additionally, because the value is not final, the JVM cannot optimize it.
      Attached patch adds the final attribute.

      Attachments

        1. EmptyParser.java.patch
          0.5 kB
          Fabian Lange

        Activity

          People

            jukkaz Jukka Zitting
            fabianlange Fabian Lange
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: