[TIKA-585] AudioParser Fails with NPE on fileFormat.properties

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.8
• Fix Version/s: 0.9
• Component/s: parser

Environment

ALL

• Assignee: Jukka Zitting
• Reporter: Cyriel Vringer
• Created: 17/Jan/11 14:47
• Updated: 02/Aug/12 09:33
• Resolved: 19/Jan/11 12:53

Description

AudioParserTests fail because the AudioParser does not check for existence of properties on the fileFormat. (In the parse method, about line 110. The code is:
for (Entry<String, Object> entry : fileFormat.properties().entrySet())

{ metadata.set(entry.getKey(), entry.getValue().toString()); }
for (Entry<String, Object> entry : audioFormat.properties().entrySet()) { metadata.set(entry.getKey(), entry.getValue().toString()); }

Method throws NPE on fileFormat.properties().entrySet() when there are no properties.
should be something like:
if( fileFormat.properties() != null && fileFormat.properties().size() > 0) {
for (Entry<String, Object> entry : fileFormat.properties().entrySet())

{ metadata.set(entry.getKey(), entry.getValue().toString()); }
}
if( audioFormat.properties() != null && audioFormat.properties().size() > 0) {
for (Entry<String, Object> entry : audioFormat.properties().entrySet()) { metadata.set(entry.getKey(), entry.getValue().toString()); }

}
Or am i missing something?