Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.17
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      tallison@mitre.org Tim Allison added a comment -

      Chris A. Mattmann, please re-open if your tests fail.

      Show
      tallison@mitre.org Tim Allison added a comment - Chris A. Mattmann , please re-open if your tests fail.
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Jenkins build Tika-trunk #1388 (See https://builds.apache.org/job/Tika-trunk/1388/)
      TIKA-2503. Need to confirm this doesn't break anything (tallison: https://github.com/apache/tika/commit/f0b6a17e5ae8b47a5b19c068e853d156775754de)

      • (edit) tika-parsers/pom.xml
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Tika-trunk #1388 (See https://builds.apache.org/job/Tika-trunk/1388/ ) TIKA-2503 . Need to confirm this doesn't break anything (tallison: https://github.com/apache/tika/commit/f0b6a17e5ae8b47a5b19c068e853d156775754de ) (edit) tika-parsers/pom.xml
      Hide
      chrismattmann Chris A. Mattmann added a comment -

      thanks Tim, no we don't have coverage. I bet that exclusion would work. I can try this week.

      Show
      chrismattmann Chris A. Mattmann added a comment - thanks Tim, no we don't have coverage. I bet that exclusion would work. I can try this week.
      Hide
      tallison@mitre.org Tim Allison added a comment -

      Thank you, Chris A. Mattmann! If I do something like this:

          <dependency>
            <groupId>edu.ucar</groupId>
            <artifactId>httpservices</artifactId>
            <version>${netcdf-java.version}</version>
            <exclusions>
              <exclusion>
                <groupId>commons-logging</groupId>
                <artifactId>commons-logging</artifactId>
              </exclusion>
              <exclusion>
                <groupId>org.apache.httpcomponents</groupId>
                <artifactId>httpclient</artifactId>
              </exclusion>
              <exclusion>
                <groupId>org.apache.httpcomponents</groupId>
                <artifactId>httpmime</artifactId>
              </exclusion>
            </exclusions>
          </dependency>
          <dependency>
            <groupId>org.apache.httpcomponents</groupId>
            <artifactId>httpclient</artifactId>
            <version>4.5.3</version>
            <exclusions>
              <exclusion>
                <groupId>commons-logging</groupId>
                <artifactId>commons-logging</artifactId>
              </exclusion>
            </exclusions>
          </dependency>
          <dependency>
            <groupId>org.apache.httpcomponents</groupId>
            <artifactId>httpmime</artifactId>
            <version>4.5.3</version>
          </dependency>
      

      Would you be able to test to make sure it works? I don't think we have coverage of opendap in our unit tests, right?

      Other options?

      Show
      tallison@mitre.org Tim Allison added a comment - Thank you, Chris A. Mattmann ! If I do something like this: <dependency> <groupId>edu.ucar</groupId> <artifactId>httpservices</artifactId> <version>${netcdf-java.version}</version> <exclusions> <exclusion> <groupId>commons-logging</groupId> <artifactId>commons-logging</artifactId> </exclusion> <exclusion> <groupId>org.apache.httpcomponents</groupId> <artifactId>httpclient</artifactId> </exclusion> <exclusion> <groupId>org.apache.httpcomponents</groupId> <artifactId>httpmime</artifactId> </exclusion> </exclusions> </dependency> <dependency> <groupId>org.apache.httpcomponents</groupId> <artifactId>httpclient</artifactId> <version>4.5.3</version> <exclusions> <exclusion> <groupId>commons-logging</groupId> <artifactId>commons-logging</artifactId> </exclusion> </exclusions> </dependency> <dependency> <groupId>org.apache.httpcomponents</groupId> <artifactId>httpmime</artifactId> <version>4.5.3</version> </dependency> Would you be able to test to make sure it works? I don't think we have coverage of opendap in our unit tests, right? Other options?
      Hide
      chrismattmann Chris A. Mattmann added a comment -

      for OpeNDAP datasets I believe we would need this...yep

      Show
      chrismattmann Chris A. Mattmann added a comment - for OpeNDAP datasets I believe we would need this...yep
      Hide
      tallison@mitre.org Tim Allison added a comment - - edited

      If I'm reading the maven dependency:tree correctly, it looks like httpclient is only used by edu.ucar:httpservices. Do we actually need that dependency? cc Chris A. Mattmann?

      Show
      tallison@mitre.org Tim Allison added a comment - - edited If I'm reading the maven dependency:tree correctly, it looks like httpclient is only used by edu.ucar:httpservices. Do we actually need that dependency? cc Chris A. Mattmann ?

        People

        • Assignee:
          tallison@mitre.org Tim Allison
          Reporter:
          tallison@mitre.org Tim Allison
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development