[TIKA-1933] ForkParser leaves tmp jars behind on Windows (at least)

• Type: Sub-task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.13

Environment

Windows 7

• Assignee: Unassigned
• Reporter: Tim Allison
• Created: 06/Apr/16 13:06
• Updated: 08/Nov/16 03:56
• Resolved: 07/Apr/16 23:26

Description

During the build process, the ForkParser is leaving behind its temp jars.

I think the process is still holding onto the jar very briefly after we destroy() it.

Java thinks the process is done – exitValue() returns 1 and then the jar fails to be deleted.

If we add waitFor() or even a sleep(10), after we destroy(), the tmp jar is deleted.

I'm always hesitant to add an unbounded waitFor() (which we'll be able to bound in Java 8). Any preferences for a fix?