[TIKA-1929] Need to close resources on exception in sqlite parser

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Assignee: Unassigned
• Reporter: Tim Allison
• Created: 04/Apr/16 17:02
• Updated: 06/Apr/16 20:06
• Resolved: 04/Apr/16 20:58

Description

If there's an exception during parsing of a SQLite file, we aren't guaranteeing that the temp file is deleted.
If a TikaInputStream is used, we assume the calling code will close the stream and thereby delete the temp file. However, if another type of InputStream is used, we copy that to a temp file, and we need to ensure that we delete that temp file if there's an exception during the parse.

While we're at it, we should also clean up test code to close streams correctly.

Unrelated to this issue... I noticed that xerial's SQLite code is still leaving behind a copy of the native dll in the temp folder on Windows the first time the SQLite parser is called. See https://github.com/xerial/sqlite-jdbc/issues/80.