[TIKA-1719] Utilize try-with-resources where it is trivial

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.11
• Component/s: cli, core, example, gui, packaging, parser, server
• Labels: easyfix
• Flags: Patch
• Assignee: Jukka Zitting
• Reporter: Yaniv Kunda
• Created: 20/Aug/15 19:48
• Updated: 31/Aug/15 04:47
• Resolved: 31/Aug/15 04:30

Description

The following type of resource usages:

    AutoCloseable resource = ...;
    try {
        // do something with resource
    } finally {
        resource.close();
    }

    AutoCloseable resource = null;
    try {
        resource = ...;
        // do something with resource
    } finally {
        if (resource != null) {
            resource.close();
        }
    }

and similar constructs can be trivially replaced with Java 7's try-with-resource statement:

    try (AutoCloseable resource = ...) {
        // do something with resource
    }

This brings more concise code with less chance of causing resource leaks.