Uploaded image for project: 'Tika'
  1. Tika
  2. TIKA-1689

Parser sort order change in TIKA-1517 breaks parser override capability

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • 1.9
    • 1.10
    • core
    • None

    Description

      In Tika 1.9, the comparator used to sort parsers (in ServiceLoaderUtils) now returns them in the reverse order from how they were returned in prior versions, when the comparator was in DefaultParser. This work was done under TIKA-1517.

      This change broke one of our customizations in which we use our own parser instead of Tika's HtmlParser to process html. We use the service loader logic (creating our own META-INF/services/org.apache.tika.parser.Parser file) and rely on the order in which the list returned by DefaultParser.getDefaultParsers() is evaluated. Expecting that when Tika builds the map of mime types to parsers it first puts in entries for HtmlParser, then overwrites these with our custom parser.

      I realize relying on this is brittle. And I found a valid workaround to the problem in Tika 1.9 is to blacklist HtmlParser. However, in case this parser ordering change was not intentional, I figured I'd mention it.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            dwarren David Warren
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment