Uploaded image for project: 'Tika'
  1. Tika
  2. TIKA-1659

ZipContainerDetector does not detect all IPA files

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.10
    • Component/s: mime
    • Labels:
      None

      Description

      ZipContainerDetector expects two files to identify the IPA file as "application/x-itunes-ipa":
      1) app/CodeResources
      2) app/ResourceRules.plist

      https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java#L386

      Recent IPA files downloaded from the App Store do not include those files. Need to update ZipContainerDetector and remove the patterns for those two files.

      1. CamLingual.ipa
        1.10 MB
        Rami Shomali
      2. hacker_news.ipa
        593 kB
        Rami Shomali

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in tika-trunk-jdk1.7 #766 (See https://builds.apache.org/job/tika-trunk-jdk1.7/766/)
        Fix for TIKA-1659 ZipContainerDetector does not detect all IPA files contributed by Rami Shomali <rami.shomali@lookout.com> this closes #51. (mattmann: http://svn.apache.org/viewvc/tika/trunk/?view=rev&rev=1687594)

        • /tika/trunk/CHANGES.txt
        • /tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in tika-trunk-jdk1.7 #766 (See https://builds.apache.org/job/tika-trunk-jdk1.7/766/ ) Fix for TIKA-1659 ZipContainerDetector does not detect all IPA files contributed by Rami Shomali <rami.shomali@lookout.com> this closes #51. (mattmann: http://svn.apache.org/viewvc/tika/trunk/?view=rev&rev=1687594 ) /tika/trunk/CHANGES.txt /tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java
        Hide
        chrismattmann Chris A. Mattmann added a comment -

        patch applied! Thanks Rami.

        [mattmann-0420740:~/tmp/tika1.10] mattmann% svn commit -m "Fix for TIKA-1659 ZipContainerDetector does not detect all IPA files contributed by Rami Shomali <rami.shomali@lookout.com> this closes #51."
        Sending        CHANGES.txt
        Sending        tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java
        Transmitting file data ..
        Committed revision 1687594.
        [mattmann-0420740:~/tmp/tika1.10] mattmann% 
        
        
        Show
        chrismattmann Chris A. Mattmann added a comment - patch applied! Thanks Rami. [mattmann-0420740:~/tmp/tika1.10] mattmann% svn commit -m "Fix for TIKA-1659 ZipContainerDetector does not detect all IPA files contributed by Rami Shomali <rami.shomali@lookout.com> this closes #51." Sending CHANGES.txt Sending tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java Transmitting file data .. Committed revision 1687594. [mattmann-0420740:~/tmp/tika1.10] mattmann%
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tika/pull/51

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tika/pull/51
        Hide
        rami Rami Shomali added a comment -

        Nick Burch, I'm attaching another sample I found that is open source. License information here:
        https://github.com/yoshiokatsuneo/camlingual_iphone

        Show
        rami Rami Shomali added a comment - Nick Burch , I'm attaching another sample I found that is open source. License information here: https://github.com/yoshiokatsuneo/camlingual_iphone
        Hide
        rami Rami Shomali added a comment -

        Here is a sample file to look at. I'll keep looking for one with Apache license. Thanks

        Show
        rami Rami Shomali added a comment - Here is a sample file to look at. I'll keep looking for one with Apache license. Thanks
        Hide
        gagravarr Nick Burch added a comment -

        Do you have a small sample IPA file that isn't detected that you could share? Ideally an Apache licensed one, but if not one we can just look at

        Show
        gagravarr Nick Burch added a comment - Do you have a small sample IPA file that isn't detected that you could share? Ideally an Apache licensed one, but if not one we can just look at
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user Rshomali opened a pull request:

        https://github.com/apache/tika/pull/51

        fix for TIKA-1659 contributed by rami

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/Rshomali/tika TIKA-1659

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tika/pull/51.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #51


        commit b333284c8d77ecc26431c765d1fba495ea168aef
        Author: Rami Shomali <rami.shomali@lookout.com>
        Date: 2015-06-18T13:02:16Z

        fix for TIKA-1659 contributed by rami


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user Rshomali opened a pull request: https://github.com/apache/tika/pull/51 fix for TIKA-1659 contributed by rami You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rshomali/tika TIKA-1659 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tika/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit b333284c8d77ecc26431c765d1fba495ea168aef Author: Rami Shomali <rami.shomali@lookout.com> Date: 2015-06-18T13:02:16Z fix for TIKA-1659 contributed by rami

          People

          • Assignee:
            chrismattmann Chris A. Mattmann
            Reporter:
            rami Rami Shomali
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development