Uploaded image for project: 'Tika'
  1. Tika
  2. TIKA-1536

Upgrade compiler definition in pom's to Java 7

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.10
    • Component/s: packaging
    • Labels:
      None

      Description

      Since we committed TIKA-1423 it would appear through mailing list commentary that there is a willingness to drop support for Java 1.6 in favour of >= Java 1.7.
      This issue simply addresses this.

      1. TIKA-1536.patch
        0.6 kB
        Lewis John McGibbney

        Activity

        Hide
        lewismc Lewis John McGibbney added a comment -

        Trivial patch for trunk. Test verified to pass.

        Show
        lewismc Lewis John McGibbney added a comment - Trivial patch for trunk. Test verified to pass.
        Hide
        tpalsulich Tyler Palsulich added a comment -

        Should we hold off on this until 2.0? Or, is it worth including in 1.8? I'm not sure which I'd prefer, but I think it's worth some discussion.

        Show
        tpalsulich Tyler Palsulich added a comment - Should we hold off on this until 2.0? Or, is it worth including in 1.8? I'm not sure which I'd prefer, but I think it's worth some discussion.
        Hide
        gagravarr Nick Burch added a comment -

        I don't think it needs to wait for 2.0 - we moved from Java 5 to 6 within the 1.x series already

        However, I think it might be best to do one more release on Java 6 which is clearly flagged as the "last Java 6 release", then upgrade after that. That would give any remaining Java 6 users time to speak up to make a case, would give them notice, and would give a clear point to work from if there was community interest in maintaining a Java 6 branch/series at a later date.

        Show
        gagravarr Nick Burch added a comment - I don't think it needs to wait for 2.0 - we moved from Java 5 to 6 within the 1.x series already However, I think it might be best to do one more release on Java 6 which is clearly flagged as the "last Java 6 release", then upgrade after that. That would give any remaining Java 6 users time to speak up to make a case, would give them notice, and would give a clear point to work from if there was community interest in maintaining a Java 6 branch/series at a later date.
        Hide
        tpalsulich Tyler Palsulich added a comment -

        Are there significant upgrades we're looking to include in 1.8 for users who would not be able to upgrade to Java 7? If not, what is the difference between releasing 1.8 with no Java 6 support and releasing 1.8 with the announcement that 1.9 will not support Java 6?

        Show
        tpalsulich Tyler Palsulich added a comment - Are there significant upgrades we're looking to include in 1.8 for users who would not be able to upgrade to Java 7? If not, what is the difference between releasing 1.8 with no Java 6 support and releasing 1.8 with the announcement that 1.9 will not support Java 6?
        Hide
        chrismattmann Chris A. Mattmann added a comment -

        I agree with Nick. However this is so trivial to support, what we can do is the following (and what I'd prefer). Let's roll a 1.7.1 which is the last Java6 release (branched from current trunk). In that branch, we'll set the compiler flag to 1.6. Then, in trunk going forward, (after the 1.7.1 release), we roll the next release (1.8) with support for Java7 going forward. Would that work? I think it that we would have to roll back Lewis's updates in the 1.7.1 branch to support GribParser then, am I correct? Or just state that GribParser doesn't work in 1.7.1?

        Show
        chrismattmann Chris A. Mattmann added a comment - I agree with Nick. However this is so trivial to support, what we can do is the following (and what I'd prefer). Let's roll a 1.7.1 which is the last Java6 release (branched from current trunk). In that branch, we'll set the compiler flag to 1.6. Then, in trunk going forward, (after the 1.7.1 release), we roll the next release (1.8) with support for Java7 going forward. Would that work? I think it that we would have to roll back Lewis's updates in the 1.7.1 branch to support GribParser then, am I correct? Or just state that GribParser doesn't work in 1.7.1?
        Hide
        tpalsulich Tyler Palsulich added a comment -

        Now that 1.9 is released, are there any blockers for upgrading to Java 1.7?

        Show
        tpalsulich Tyler Palsulich added a comment - Now that 1.9 is released, are there any blockers for upgrading to Java 1.7?
        Hide
        grossws Konstantin Gribov added a comment -

        Did we announced that current release will be last supports java 1.6 somewhere?

        Show
        grossws Konstantin Gribov added a comment - Did we announced that current release will be last supports java 1.6 somewhere?
        Show
        tpalsulich Tyler Palsulich added a comment - Yep, see http://apache.markmail.org/thread/7oubuh4hp6rdlbch .
        Hide
        lewismc Lewis John McGibbney added a comment -

        +1 to upgrade. Nice one Tyler.

        Show
        lewismc Lewis John McGibbney added a comment - +1 to upgrade. Nice one Tyler.
        Hide
        tpalsulich Tyler Palsulich added a comment -

        Upgraded in r1688779. Thanks, all. Will open a new issue regarding integrating tika-java7.

        Show
        tpalsulich Tyler Palsulich added a comment - Upgraded in r1688779. Thanks, all. Will open a new issue regarding integrating tika-java7.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in tika-trunk-jdk1.7 #779 (See https://builds.apache.org/job/tika-trunk-jdk1.7/779/)
        TIKA-1536. Update CHANGES.txt with upgrade to Java 7. (tpalsulich: http://svn.apache.org/viewvc/tika/trunk/?view=rev&rev=1688780)

        Show
        hudson Hudson added a comment - SUCCESS: Integrated in tika-trunk-jdk1.7 #779 (See https://builds.apache.org/job/tika-trunk-jdk1.7/779/ ) TIKA-1536 . Update CHANGES.txt with upgrade to Java 7. (tpalsulich: http://svn.apache.org/viewvc/tika/trunk/?view=rev&rev=1688780 ) /tika/trunk/CHANGES.txt TIKA-1536 . Upgrade to Java 1.7. (tpalsulich: http://svn.apache.org/viewvc/tika/trunk/?view=rev&rev=1688779 ) /tika/trunk/pom.xml /tika/trunk/tika-parent/pom.xml

          People

          • Assignee:
            lewismc Lewis John McGibbney
            Reporter:
            lewismc Lewis John McGibbney
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development