[TIKA-1137] Wasted work in WontBeSerializedError.writeObject()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3
• Component/s: parser
• Labels: patch perfomance

Environment

any

• Assignee: Tyler Bui-Palsulich
• Reporter: Adrian Nistor
• Created: 18/Jun/13 23:50
• Updated: 15/Mar/15 02:46
• Resolved: 15/Mar/15 02:10

Description

The problem appears in version 1.3 and in revision 1494353. I
attached a one-line patch that fixes it.

In method "WontBeSerializedError.writeObject", the loop over
"e.getStackTrace()" should break immediately after "found" is set to
"true". All the iterations after "found" is set to "true" do not
perform any useful work, at best they just set "found" again to
"true".

Method "embedInTempFile" in class "ExternalEmbedderTest" has a similar
loop (over "embeddedMetadata.getValues(metadataName)"), and this loop
breaks immediately after "foundExpectedValue" is set to "true", just
like in the proposed patch.