Thrift
  1. Thrift
  2. THRIFT-960

add TestServer, TestNonblockingServer and TestClient again

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5
    • Fix Version/s: 0.6
    • Component/s: Java - Library, Test Suite
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      • add TestServer, TestNonblockingServer and TestClient again (deleted by revision #927693)
      • TestHandler from ServerTestBase inside TestServer and TestNonblockingServer
      • create a libthrift-test.jar containing the testsuite, this will allow other testsuites e.g. JavaScript to use the same TestHandler
      • ant targets testclient, testserver and testnonblockingserver will be able to run

        Issue Links

          Activity

          Hide
          Roger Meier added a comment -

          please review the patch, i like to commit this soon.

          Show
          Roger Meier added a comment - please review the patch, i like to commit this soon.
          Hide
          Bryan Duxbury added a comment -

          Why all the changes to the classpath stuff in build.xml? Looks a little confusing to me.

          Show
          Bryan Duxbury added a comment - Why all the changes to the classpath stuff in build.xml? Looks a little confusing to me.
          Hide
          Roger Meier added a comment -

          You are right Bryan, the classpath modifications are not required.

          I had a closer look,
          add the depends to the testserver target is enough because it depends on resolve which sets the ivy.test.classpath => new patch without classpath modifications.

          Show
          Roger Meier added a comment - You are right Bryan, the classpath modifications are not required. I had a closer look, add the depends to the testserver target is enough because it depends on resolve which sets the ivy.test.classpath => new patch without classpath modifications.
          Hide
          Roger Meier added a comment -

          classpath issue was fixed and no other concerns occurred, so I committed that.

          Show
          Roger Meier added a comment - classpath issue was fixed and no other concerns occurred, so I committed that.
          Hide
          Roger Meier added a comment -

          I'm very sorry about these extra commits and late changes... I forgot to adopt to AbstractServerArgs .introduced with THRIFT-745 ...

          Show
          Roger Meier added a comment - I'm very sorry about these extra commits and late changes... I forgot to adopt to AbstractServerArgs .introduced with THRIFT-745 ...
          Hide
          Roger Meier added a comment -

          one more ... removed TestServer, TestNonblockingServer and TestClient from Unittest

          Show
          Roger Meier added a comment - one more ... removed TestServer, TestNonblockingServer and TestClient from Unittest

            People

            • Assignee:
              Roger Meier
              Reporter:
              Roger Meier
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development