Thrift
  1. Thrift
  2. THRIFT-941

Make PHP C Extension use the defined Protocol writeMessageBegin function

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6
    • Component/s: PHP - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The current PHP C Extension implementation hard codes writeMessageBegin that is from TBinaryProtocol in C land. I think the correct implementation should support calling into user-land from PHP if you have a protocol that might change how writeMessageBegin works. I built a tracing library that needed to pass additional fields with the RPC request.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        3d 2h 14m 1 Bryan Duxbury 06/Oct/10 00:23
        Bryan Duxbury made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 0.6 [ 12315359 ]
        Resolution Fixed [ 1 ]
        Hide
        Bryan Duxbury added a comment -

        I just committed this. Thanks for the patch, Chris!

        Show
        Bryan Duxbury added a comment - I just committed this. Thanks for the patch, Chris!
        Chris Goffinet made changes -
        Field Original Value New Value
        Attachment 0001-Support-custom-writeMessageBegin-functions-from-user.patch [ 12456213 ]
        Chris Goffinet created issue -

          People

          • Assignee:
            Chris Goffinet
            Reporter:
            Chris Goffinet
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development