[THRIFT-899] Ruby read timeouts can sometimes be 2x what they should be

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1, 0.2, 0.3, 0.4
• Fix Version/s: 0.5
• Component/s: Ruby - Library
• Patch Info: Patch Available
• Assignee: Ryan King
• Reporter: Ryan King
• Created: 16/Sep/10 21:10
• Updated: 17/Sep/10 20:18
• Resolved: 17/Sep/10 20:17

Description

Thrift::Socket#read will sometimes fail to enforce a timeout properly and wait approximately 2x @timeout before timing out the request.

Our testing via thrift_client (http://github.com/fauna/thrift_client) would only fail about 1/20 of the time. My hypothesis is that it only fails when you have a floating-point rounding error (we set the timeout to 0.8 seconds, but the math gave us 0.7999, so we wait another 0.8 seconds).

The patch doesn't have any tests, because this problem is non-deterministic. (also, I couldn't figure out how to run the tests)