[THRIFT-896] TNonblockingSocket.isOpen() returns true even after close()

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.4, 0.5
• Fix Version/s: 0.5
• Patch Info: Patch Available
• Assignee: Eric Jensen
• Reporter: Eric Jensen
• Created: 10/Sep/10 02:43
• Updated: 10/Sep/10 19:08
• Resolved: 10/Sep/10 19:08

Description

SocketChannel.isConnected() has this broken behavior http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6341625, but TSocket corrects it by setting its Socket to null in close() and then checking that in isOpen(). This patch does something similar by checking SocketChannel.isOpen() which has the correct semantics. Added an assertion that exposed the previous failure. Also remove reference to derived Socket since it just confused matters.