Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5
    • Fix Version/s: 0.5
    • Component/s: Compiler (General)
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The patch from THRIFT-857, applied as r987565, didn't work for smalltalk. (sorry, I tested it with python, and didn't look too hard at the smalltalk)

      However, there's a bigger problem that the smalltalk generator is calling back into program_ to lookup namespaces using "smalltalk.<foo>" while it's registered as a generator for "st" so the root namespace check only allows "st.foo" namespaces. I really hate this, but if there are people expecting "namespace smalltalk" to work, maybe the best fix would be to hard-code the converstion to "st":

      (note: I ran the smalltalk generator this time to make sure the "category" line was there, but would in no way claim to have tested the smalltalk.)

      1. ns_smalltalk.patch
        1 kB
        Bruce Lowekamp

        Activity

        Hide
        Bryan Duxbury added a comment -

        I just committed this. I added a warning message to our special case indicating that it was deprecated.

        Thanks for the patch, Bruce!

        Show
        Bryan Duxbury added a comment - I just committed this. I added a warning message to our special case indicating that it was deprecated. Thanks for the patch, Bruce!

          People

          • Assignee:
            Bruce Lowekamp
            Reporter:
            Bruce Lowekamp
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development