[THRIFT-877] smalltalk namespace doesn't work

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5
• Fix Version/s: 0.5
• Component/s: Compiler (General)
• Patch Info: Patch Available
• Assignee: Bruce Lowekamp
• Reporter: Bruce Lowekamp
• Created: 30/Aug/10 00:31
• Updated: 30/Aug/10 17:12
• Resolved: 30/Aug/10 17:12

Description

The patch from THRIFT-857, applied as r987565, didn't work for smalltalk. (sorry, I tested it with python, and didn't look too hard at the smalltalk)

However, there's a bigger problem that the smalltalk generator is calling back into program_ to lookup namespaces using "smalltalk.<foo>" while it's registered as a generator for "st" so the root namespace check only allows "st.foo" namespaces. I really hate this, but if there are people expecting "namespace smalltalk" to work, maybe the best fix would be to hard-code the converstion to "st":

(note: I ran the smalltalk generator this time to make sure the "category" line was there, but would in no way claim to have tested the smalltalk.)