[THRIFT-851] php extension fails to compile on centos 5.x

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.4
• Fix Version/s: 0.5
• Component/s: PHP - Library
• Patch Info: Patch Available
• Assignee: Todd Lipcon
• Reporter: Anthony Molinaro
• Created: 14/Aug/10 07:03
• Updated: 01/Sep/10 19:01
• Resolved: 17/Aug/10 17:45

Description

At some point the includes for endian.h and byte_order.h were changed from

#include <endian.h>
#include <byteswap.h>

to

#include <machine/endian.h>
#include <machine/byte_order.h>

Unfortunately the latter files only exist on bsd and bsd derived systems like Mac OSX.

I fixed it by using some ifdef's and using the old includes on linux.

Patch is attached