Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-834

THttpClient resends contents of message after transport errors

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.4
    • 0.4
    • C# - Library
    • None
    • Patch Available

    Description

      Currently, THttpClient attempts to send an HTTP request on Flush(). It also waits for the response in this method. In case of a successful web request, the output stream(send) is reset. In case of a transport error, the send buffer is retained, causing the next web request to contain the data that was previously sent.

      The fix is pretty simple. I am attaching a patch.

      Attachments

        1. thttp_error_handle_patch.patch
          0.5 kB
          Anatoly Fayngelerin

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-616 Transport should be reset on error

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-4564 TBufferedTransport can leave corrupt data in the buffer

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              fanatoly Anatoly Fayngelerin
              fanatoly Anatoly Fayngelerin
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: