Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-815

Deserialization of lists is critically broken.

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 0.4
    • 0.4
    • JavaScript - Compiler
    • None

    Description

      Edit the test code that comes with the js language target:

      var list = [1,2,3];
      var ret = client.testList(list);
      debugger;

      ret comes back as [3,3,3] when it should be echoed back as [1,2,3]
      The test case never caught this because it only verified the size, and not the contents of the returned array.
      I cannot find an immediate workaround, but I will try wrapping it in a dummy type like ListServiceResponse.

      Attachments

        1. THRIFT-815_thrift.js.patch
          1 kB
          Roger Meier
        2. THRIFT_815_TestFramework_test.html_json2.patch
          30 kB
          Roger Meier
        3. test.html
          8 kB
          Roger Meier
        4. 813-1.patch
          1 kB
          T Jake Luciani

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tjake T Jake Luciani
            jordo Jordan
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment