Details

    • Patch Info:
      Patch Available

      Description

      I've created patch, with which you can generated namespaces as defines in
      PHP5.3, i.e. \Thrift\SharedServiceIf etc.
      With this patch, thrift php generator will recognize two new parameters:

      • namespace53 - generate namespaces as defines in PHP 5.3. Without it, it
        generates same code as before
      • nsglobal - global namespace, default is Thrift. From tutorial, it will
        create classes \Thrift\tutorial\CalculatorIf etc.

      What can I do to make it attached to trunk? Thanks for any ideas, because
      I'm very new to Thrift and also open-source development.

      Link: http://helemik.cz/juzna/opensource/php/thrift/php53.patch

        Issue Links

          Activity

          Hide
          Bryan Duxbury added a comment -

          Jan - can you post the patch on this issue and check the ASF contribution box? I'll review it for commit then. (Sorry about the long wait for attention.)

          Show
          Bryan Duxbury added a comment - Jan - can you post the patch on this issue and check the ASF contribution box? I'll review it for commit then. (Sorry about the long wait for attention.)
          Hide
          Roger Meier added a comment -

          just committed THRIFT-1241

          Show
          Roger Meier added a comment - just committed THRIFT-1241
          Hide
          Hudson added a comment -

          Integrated in Thrift #217 (See https://builds.apache.org/job/Thrift/217/)
          THRIFT-1241 php namespace generation
          realization of THRIFT-777

          roger : http://svn.apache.org/viewvc/?view=rev&rev=1154045
          Files :

          • /thrift/trunk/compiler/cpp/src/generate/t_php_generator.cc
          Show
          Hudson added a comment - Integrated in Thrift #217 (See https://builds.apache.org/job/Thrift/217/ ) THRIFT-1241 php namespace generation realization of THRIFT-777 roger : http://svn.apache.org/viewvc/?view=rev&rev=1154045 Files : /thrift/trunk/compiler/cpp/src/generate/t_php_generator.cc

            People

            • Assignee:
              Unassigned
              Reporter:
              Jan Dolecek
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.5h
                0.5h
                Remaining:
                Remaining Estimate - 0.5h
                0.5h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development