[THRIFT-762] Cocoa library won't compile on Mac OS X

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 0.2, 0.3
• Component/s: Cocoa - Library

Environment

Mac OS X Snow Leopard 10.6, Mac OS X Leopard 10.5

• Patch Info: Patch Available
• Assignee: Andrew McGeachie
• Reporter: Jeremy Fergason
• Created: 21/Apr/10 07:29
• Updated: 08/Jun/13 17:53
• Resolved: 08/Jun/13 17:53

Description

The cocoa library will not compile for Objective-C Cocoa applications on Mac OS X because it tries to include <CFNetwork/CFSocketStream.h> in transport/TSocketClient.m. This should be a pound-define that includes <CoreServices/CoreServices.h> if being compiled on Mac OS X or <CFNetwork/CFNetwork.h> if being compiled for iPhone OS.

Also, the Mac OS X build will give a warning because the NSStreamDelegate protocol is not implemented in transport/TNSStreamTransport.

{h,m}

I have attached a patch to fix both issues.