[THRIFT-735] Required field checking is broken when the field type is a Union struct

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.2
• Component/s: Java - Compiler, Java - Library
• Assignee: Bryan Duxbury
• Reporter: Bryan Duxbury
• Created: 15/Mar/10 23:39
• Updated: 05/Aug/10 22:41

Description

The validate() method on generated structs verifies that required fields are set after validation. However, if the type of the field is a Union struct, then just checking that the field isn't null is not a valid check. The value may be a non-null union, but have an unset field. (We encountered this when deserializing a type that had a union for a field, and the union's set value was an enum value that had been removed from the definition, making it a skip.)

In order to perform the correct validation, if the value is a Union, then we must also check that the set field and value are non-null.