[THRIFT-705] Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: C++ - Library

Environment

Any Thrift compatible C++ compiler environment.

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Teemu Koponen
• Created: 16/Feb/10 04:08
• Updated: 21/Aug/14 17:51
• Resolved: 11/Dec/11 21:13

Description

The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:

http://sources.redhat.com/autobook/autobook/autobook_96.html

Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:

http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html

The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.